Skip to content

SFT-7110: message signing display mismatch #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjg-foundation wants to merge 2 commits into
base: dev-v2.4.0
Choose a base branch
from
Open

SFT-7110: message signing display mismatch #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b35c185
SFT-7110: escaped some text, removed flag to permit non-ascii characters
mjg-foundation Jun 8, 2026
0f77641
Keep OP_RETURN handling with transaction review changes
Jacksper13 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ports/stm32/boards/Passport/modules/flows/sign_electrum_message_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from flows import Flow, ScanQRFlow
from pages import ErrorPage, LongTextPage, LongQuestionPage, ShowQRPage
from tasks import sign_text_file_task, validate_electrum_message_task
from utils import spinner_task, stylize_address
from utils import escape_text, spinner_task, stylize_address
from data_codecs.qr_type import QRType
import microns
from wallets.utils import get_addr_type_from_deriv
Expand Down Expand Up @@ -62,7 +62,7 @@ async def show_message(self):
display_address = stylize_address(self.address)

result = await LongTextPage(centered=True,
text=('\n' + self.message),
text=('\n' + escape_text(self.message)),
card_header={'title': 'Message'}).show()

if not result:
Expand Down
4 changes: 2 additions & 2 deletions ports/stm32/boards/Passport/modules/flows/sign_psbt_common_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from styles.colors import HIGHLIGHT_TEXT_HEX, BLACK_HEX
from tasks import sign_psbt_task, validate_psbt_task
import gc
from utils import spinner_task, recolor, stylize_address
from utils import escape_text, spinner_task, recolor, stylize_address


class SignPsbtCommonFlow(Flow):
Expand Down Expand Up @@ -274,7 +274,7 @@ def render_warnings(self):
if self.psbt.warnings and len(self.psbt.warnings) > 0:
msg.write('\n\n{}'.format(recolor(HIGHLIGHT_TEXT_HEX, 'Warnings')))
for label, m in self.psbt.warnings:
msg.write('\n{}\n{}\n'.format(recolor(BLACK_HEX, label), m))
msg.write('\n{}\n{}\n'.format(recolor(BLACK_HEX, escape_text(label)), escape_text(m)))
gc.collect()

return msg.getvalue()
3 changes: 1 addition & 2 deletions ports/stm32/boards/Passport/modules/tasks/validate_electrum_message_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ async def validate_electrum_message_task(on_done, message):
(subpath, error) = validate_sign_text(message,
header_elements[1],
space_limit=False,
check_whitespace=False,
check_ascii=False)
check_whitespace=False)

if error:
await on_done(None, error)
Expand Down