Fix linux-arm64 artifact shipping x64 Go binary - #21
Open
jackgopack4 wants to merge 1 commit into
Open
Conversation
Add goarch field to Linux matrix entries and pass GOARCH/CGO_ENABLED env vars to the Linux Go build step so cross-compilation produces the correct ARM64 binary on the x64 ubuntu-latest runner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks. Added to my review todo-list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goarchfield to both Linux matrix entries (amd64for linux-x64,arm64for linux-arm64)GOARCH: ${{ matrix.goarch }}andCGO_ENABLED: 0as env vars on the Linux Go build stepCGO_ENABLED: 0is required for cross-compilation on the x64 runner; consistent with existing static build flags (-tags=netgo,osusergo,static_build,-ldflags '-d -s -w -extldflags=-static')Fixes #12
Verification
All 4 matrix jobs passed on fork CI:
Binary arch confirmed with
file:linux-arm64/local-gpss→ELF 64-bit LSB executable, ARM aarch64linux64/local-gpss→ELF 64-bit LSB executable, x86-64Test plan
linux-arm64artifact binary showsELF 64-bit LSB executable, ARM aarch64viafilelinux64artifact binary still showsx86-64viafile