Upgrade GitHub Actions to Node.js 24 runtime (issue #19) - #20
Open
jackgopack4 wants to merge 9 commits into
Open
Upgrade GitHub Actions to Node.js 24 runtime (issue #19)#20jackgopack4 wants to merge 9 commits into
jackgopack4 wants to merge 9 commits into
Conversation
- Bump .NET SDK from 9.0.x to 10.0.x (PKHeX.Core now targets net10.0) - Update hardcoded net9.0 paths to net10.0 in copy and xcopy steps - Fix wrong GpssConsole.csproj path (missing GpssConsole/ subdirectory) - Use dynamic default branch for git push instead of hardcoded master Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace EntityContext.Generation() with PKM.Format (C# 14 extension member syntax not accessible from GpssConsole) - Replace DecryptedBoxData/DecryptedPartyData with WriteDecryptedDataStored/ WriteDecryptedDataParty Span-based API - Update bundled DLLs to latest PKHeX.Core and PKHeX.Core.AutoMod (net10.0) Closes FlagBrew#18. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Bump all actions off Node.js 20 before the June 2, 2026 forced migration: - actions/checkout v4 -> v6 - actions/setup-dotnet v4 -> v5 - actions/upload-artifact v4 -> v7 - actions/download-artifact v4 -> v8 - softprops/action-gh-release v2 -> v3 - microsoft/setup-msbuild v2 -> v3 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks. Added to my review todo-list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19.
Bumps all actions off Node.js 20 ahead of the June 2, 2026 forced migration deadline.
actions/checkoutv4v6actions/setup-dotnetv4v5actions/upload-artifactv4v7actions/download-artifactv4v8softprops/action-gh-releasev2v3microsoft/setup-msbuildv2v3actions/setup-go@v6was already on node24 — no change needed.All bumps are drop-in replacements. The only behavioral change is
download-artifact@v8now errors on hash mismatches by default (previously warned); this is safe here since artifacts are uploaded and downloaded within the same run.Verification
Both workflows tested on fork with updated action versions: