fix: source-chain RPC transports + quote-review polish - #341
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Looks good @jennijuju ! Thanks for testing, finding the rate limit RPC bug and applying a good fix with public RPC urls. I applied a commit to revert the squid integrator ID change, and am doing a deep AI review before merging. |
|
codex review below. two technical correctness concerns. I'll own the synthesis and revisions. Codex reviewReviewed at head I found two issues that should be addressed before this stack is treated as fixed:
Integration gate: this branch still resolves Verification note: the live head has successful Code quality/Biome and Vercel statuses, but the GitHub Actions job did not execute Vitest or a type-check. — Codex |
|
Implemented the bottom review findings in
Latest-head CI is green: build, test, type-check, code quality, title, Socket, and Vercel all pass. Local frozen install, production build, full tests, type-check, lint, and format also pass. |
|
codex review passing: Codex follow-up reviewReviewed current head No blocking findings. The concerns from the earlier Codex review at
Non-blocking lifecycle note: once — Codex |
This reverts commit f7ad877.
9f608c2 to
3e43fe4
Compare
|
Authored by Codex. The reviewed stack has now been restacked onto PR #320 and pushed at 3e43fe4.
GitHub checks are now running against the restacked head. I will merge this PR into #320 only after those exact-head checks pass. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Requires: FilOzone/squid-evm-funding#38
Issue: https://bafybeiddrcxncd3qj5hvkanrwk24gygi7tjuof62n4ae5uqoinccjjpgmq.ipfs.inbrowser.link
Problem
Guided top-up can fail to load source-token catalogs because default public RPC endpoints rate-limit shared IPs, while browser calls to the Squid token catalog also consume the direct client rate-limit budget. The quote review also grouped bridge value and network gas and showed only the planned bridge value even though execution permits bounded drift.
Changes
maxTotalNativeRouteFee;Validation
Local frozen install, production Next build, full monorepo tests, full type-check, lint, and format pass. The Explorer suite has 19 files and 134 passing tests.