Keep non-JPEG channel shapes in raw storage - #356
Open
betacatsling wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image-space predicate treats every uint8 HWC channel count as JPEG-compatible. Collection therefore fails for singleton-channel, two-channel and RGBA observations. Restrict automatic JPEG encoding to two-dimensional grayscale and three-channel RGB; store other shapes as raw arrays so all channels and values survive.
Validation: 9 failed / 2 passed on the unchanged base; 130 passed after the fix, including real Arrow, Parquet and HDF5 round trips. Black/isort and diff checks passed. CPU/local storage only; no GPU, MuJoCo or remote dataset claims. The relevant API documentation is updated.
AI assistance was used for implementation and local verification.
Fixes #355.