Close temporary environments used to infer storage spaces - #354
Open
betacatsling wants to merge 1 commit into
Open
betacatsling wants to merge 1 commit into
betacatsling wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MinariStorage.new() and read() construct Gymnasium environments when space metadata is missing but never close them. Close these private temporary environments after extracting the spaces, including on errors. The tests register a real Gymnasium environment and verify one close per construction with either or both spaces missing.
Validation: 6 failed on the unchanged base; 125 passed after the fix, including serialization and storage tests. Black/isort and diff checks passed. CPU/local storage only; no GPU, MuJoCo or remote dataset claims. The relevant API documentation is updated.
AI assistance was used for implementation and local verification.
Fixes #353.