[BugFix] _set_obj_xyz in stick-push/stick-pull uses wrong qvel indices, causing object to drift after reset - #584
Open
15101051 wants to merge 4 commits into
Open
[BugFix] _set_obj_xyz in stick-push/stick-pull uses wrong qvel indices, causing object to drift after reset#58415101051 wants to merge 4 commits into
15101051 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SawyerStickPushEnvV3 and SawyerStickPullEnvV3, the
_set_obj_xyzmethod zeroesqvel[16:18]to clear the object's velocity. However, due to the stick body using a free joint (7 qpos but only 6 qvel components), there is a +1 offset between qpos and qvel indices for all bodies defined after the stick.The object's slide joint velocities are actually at
qvel[15:17], notqvel[16:18].Observed behavior: After
reset(), the thermos retains a nonzero x-velocity (~0.68) from the_reset_hand()simulation steps. It slides along +x until hitting the joint limit (offset = 0.2, world x ≈ 0.4), which coincidentally aligns with the target position — making it appear as if the object "teleports" to the goal.Affected files:
metaworld/envs/sawyer_stick_push_v3.pymetaworld/envs/sawyer_stick_pull_v3.py