Skip to content

Adding timeout termination to PitFall #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sebastian-Griesbach wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Adding timeout termination to PitFall #667

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
25cbca8
Adding timeout termination to PitFall
Sebastian-Griesbach Feb 5, 2026
ef56980
game mode as option to disable timeout termination
Sebastian-Griesbach Feb 9, 2026
0737f12
cleaning comments
Sebastian-Griesbach Feb 17, 2026
927009a
Revert "cleaning comments"
Sebastian-Griesbach May 18, 2026
e95e35d
Revert "game mode as option to disable timeout termination"
Sebastian-Griesbach May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/ale/games/supported/Pitfall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,14 @@ void PitfallSettings::step(const System& system) {

// update terminal status
int lives_byte = readRam(&system, 0x80) >> 4;
// The value at 09xE will be nonzero if we cannot control the player
// The value at 0x9E will be nonzero if we cannot control the player
int logo_timer = readRam(&system, 0x9E);
m_terminal = lives_byte == 0 && logo_timer != 0;
// The game timer (displayed as MM:SS) is stored in BCD format at 0xD8 (minutes) and 0xD9 (seconds)
int timer_minutes = readRam(&system, 0xD8);
int timer_seconds = readRam(&system, 0xD9);
// Game terminates when: (1) all lives lost and logo screen shown, OR (2) timer runs out (00:00)
bool timer_expired = (timer_minutes == 0 && timer_seconds == 0);
m_terminal = (lives_byte == 0 && logo_timer != 0) || timer_expired;

m_lives = (lives_byte == 0xA) ? 3 : ((lives_byte == 0x8) ? 2 : 1);
}
Expand Down
Loading