Refactor frame processing & add frame maxing - #495
Open
JesseFarebro wants to merge 256 commits into
Open
Conversation
Add mode support for Galaxian
…_prob Reset actions on reset
Removed extra curly brace from example agent
…to-sdl-header-not-found-problem workaround for SDL header not found problem
Fix switch fall-through in Gravitor.cpp
eliminating variables which are constant. Benchmarking shows avg. ~30% speedup on multiple Atari games.
Optimize Atari emulator by ~30%
[Paddles.hxx] Add missing includion of Event.hxx
Also check in a .gitattributes file to set "text=auto". This affects only a few odd files that had CRLF endings; most files already have LF endings.
This simplifies the toolchain selection.
Previously, the values were hardcoded macros. Those are retained as the default value, but the effective values may now be set programmatically. This changes the serialization format (the paddle values now appear as the last two values).
Travis only provides two cores, so it is not useful to run make with more than two jobs.
This change only modifies whitespace (and adds one or two #ifdef
comments). The reformatting is based on clang-format, with manual
review and tweaking.
The goal to harmonize the source code formatting, which is currently
using a variety of local styles. The chosen format is a "compact"
one (as per clang-format default): 2-space indent, Egyptian braces.
Nonetheless, vertical whitespace has been adjusted generously, so as
to have line comments preceded by a blank line for easy visual
segmentation.
Created with:
clang-format \
--sort-includes=false \
--style='{ReflowComments: false,
PointerAlignment: Left,
KeepEmptyLinesAtTheStartOfBlocks: false,
IndentCaseLabels: true,
AccessModifierOffset: -1}'
sed -e 's%#endif //%#endif //%g'
This change only modifies whitespace (and adds one or two #ifdef
comments). The reformatting is based on clang-format, with manual
review and tweaking.
The goal to harmonize the source code formatting, which is currently
using a variety of local styles. The chosen format is a "compact"
one (as per clang-format default): 2-space indent, Egyptian braces.
Nonetheless, vertical whitespace has been adjusted generously, so as
to have line comments preceded by a blank line for easy visual
segmentation.
Created with:
clang-format \
--sort-includes=false \
--style='{ReflowComments: false,
PointerAlignment: Left,
KeepEmptyLinesAtTheStartOfBlocks: false,
IndentCaseLabels: true,
AccessModifierOffset: -1}'
sed -e 's%#endif //%#endif //%g'
…dation#476) * add render_mode attribute * add blank line back
Two problems existed with parsing some ROM names: 1) If the ROM had a number it would be parsed invalidly, e.g., TicTacToe3D, Pitfall2. 2) Videochess & Videocube didn't follow the same naming convention as VideoCheckers and VideoPinball.
This fixes a problem with pytype where it checks hardcoded decorators and only includes `@overload` and not `@typing.overload`.
Member
|
Will this require environment version update? |
Member
|
@JesseFarebro would you be willing to fix merge conflicts on this? |
Kallinteris-Andreas
force-pushed
the
main
branch
from
July 13, 2026 04:59
a42e8ad to
4642385
Compare
Member
|
Would you be willing to create a new version of this PR with the merge conflicts fixed so it can be reviewed as well? |
|
@jkterry1 I will take a look at it soon. For now I should stop procrastinating on my own work with ALE PRs... |
Member
|
@Sebastian-Griesbach poke about creating a new mergable PR off this if you're willing and have a moment, I'd greatly appreciate it :) |
|
@jkterry1 I'm quit busy at the moment with hopefully my next publication. I will take a look at it eventually. As I understood @pseudo-rnd-thoughts the timeline to new new release are a few Month, until then I will likely have had a crack at it. |
Member
|
@teddytennant would you be so kind as to create a new PR replacing this one that's rebased off master and passes CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Frame Maxing details
As for frame maxing, we perform frame maxing per channel if
getScreenRGBis called. This is standard and what DeepMind's preprocessing does. IfgetScreenGrayscaleis called then we just take the max over luminosity.Fixes #467.