Allow access wideners to modify any game or mod class, not only MC - #1055
Draft
Player3324 wants to merge 1 commit into
Draft
Allow access wideners to modify any game or mod class, not only MC#1055Player3324 wants to merge 1 commit into
Player3324 wants to merge 1 commit into
Conversation
LlamaLad7
approved these changes
Jun 22, 2025
Gamebuster19901
approved these changes
Jun 22, 2025
Gamebuster19901
suggested changes
Jun 22, 2025
| @@ -30,7 +30,7 @@ public static byte[] transform(boolean isDevelopment, EnvType envType, String na | |||
| boolean isMinecraftClass = name.startsWith("net.minecraft.") || name.startsWith("com.mojang.blaze3d.") || name.indexOf('.') < 0; | |||
Contributor
There was a problem hiding this comment.
I believe this line can be removed too.
Contributor
Author
There was a problem hiding this comment.
I actually have another PR at #1056 that changes how this works, if the idea in this PR is accepted I'll rebase it onto that
modmuss50
approved these changes
Jun 23, 2025
Contributor
Author
|
Draft pending update for code changes in 1056 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think it's necessary to keep the restriction to Minecraft classes only. Fabric tends to be less restrictive and there are already ways to hack around it anyway.
Fixes part of #1049 and #1043
Note this would come on top of #1055 - making GameProvider.getBuiltinTransforms include
BuiltinTransform.CLASS_TWEAKSin all cases. Other game provider can choose different behaviors.