emit: sequence a unit after a conditional that names its join state - #245
Draft
nikswamy wants to merge 1 commit into
Draft
emit: sequence a unit after a conditional that names its join state#245nikswamy wants to merge 1 commit into
nikswamy wants to merge 1 commit into
Conversation
Pulse rejects an annotated conditional in tail position: the annotation and the enclosing signature's postcondition are two postconditions for the same term, and the checker reports the pair rather than reconciling them. Emitting a unit after the conditional keeps the annotation local to the join, which is the only place it constrains anything. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 981f7d3c-6a91-47ad-84d7-7aadf747123d (cherry picked from commit 6578d2a)
gebner
requested changes
Aug 24, 2026
gebner
left a comment
gebner
left a comment
Contributor
There was a problem hiding this comment.
Pulse bug. Please refile to fstarlang/fstar.
Contributor
|
!diff |
Generated F* output diffEffect of this pull request on the F* code ✅ The generated output is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the upstreaming of
nswamy/pal-c-project-integration(PR31 of 35 PRs) — seePR_PLAN.mdon that branch for the whole plan and the dependency graph.Base:
main. Depends on nothing; reviewable on its own.Pulse rejects an annotated conditional in tail position: the annotation and the enclosing
signature's postcondition are two postconditions for the same term. Sequencing a unit after
it keeps the annotation local to the join, which is the only place it constrains anything.
Commits
Testing
No test directory of its own — this is an enabler whose effect shows up in another PR's fixture, a
pulse/library lemma, or atests-todoreproducer. Verified with a fullmake test -j8(1372 modules, 0 errors) to confirm it regresses nothing.