Skip to content

Type switch scrutinee bindings by their enumeration type #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nikswamy wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Type switch scrutinee bindings by their enumeration type #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions cpp/impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1891,8 +1891,20 @@ class PALConsumer : public ASTConsumer {

// Evaluate scrutinee
auto scrutRval = trRValue(sw->getCond());
auto scrutTy =
trQualType(sw->getCond()->getType(), sw->getCond()->getSourceRange());
// Clang applies the integral promotions to the switch condition. An
// enumeration is modeled by its underlying integer type, so that
// promotion translates to the identity and is elided from the rvalue.
// Annotating the binding with the promoted type would then leave the
// declared type and the translated value syntactically distinct, which
// the Pulse dereference tactic rejects. Use the enumeration's own type
// so the two agree; other promotions are genuine casts that trRValue
// preserves, so their promoted type remains correct.
auto *scrutExpr = sw->getCond();
auto scrutQualTy = scrutExpr->getType();
if (scrutExpr->IgnoreImpCasts()->getType()->isEnumeralType()) {
scrutQualTy = scrutExpr->IgnoreImpCasts()->getType();
}
auto scrutTy = trQualType(scrutQualTy, scrutExpr->getSourceRange());

// Bind the scrutinee once as an immutable value.
static int switchCounter = 0;
Expand Down
Loading