Skip to content

Sanitize newlines in QR serialized text fields #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Owen-Morgan825 merged 1 commit into from
Apr 28, 2026
Merged

Sanitize newlines in QR serialized text fields #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/QR/QRModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,18 @@ import {
} from '../ui/dialog';
import { PreviewText } from './PreviewText';

function removeNewlines(value: string): string {
return value.replace(/\r\n|\r|\n/g, ' ');
}

/** Serialize a field value for QR code or display; TBA-team-and-robot is stored as an object. */
function fieldValueToQrString(value: unknown): string {
if (value != null && typeof value === 'object' && 'teamNumber' in value) {
const { teamNumber } = value as { teamNumber: number };
return String(teamNumber);
}
if (value === null || value === undefined) return '';
return String(value);
return removeNewlines(String(value));
}

export interface QRModalProps {
Expand Down
Loading