ci(security): enable Dependency-Track scanning - #262
Open
tokland wants to merge 1 commit into
Open
Conversation
Without the secret, the shared workflow skips both dependency-track jobs and still reports success, so the repository has never been scanned. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UyMSoPhgMHdJXdAzYBE9aP
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mergeable, so from now on we get security reviews for that repository.
This PR has been opened to review the draft Resolving Dependency Vulnerabilities wiki page, to test its process end to end against a real repository.
Summary
The repository calls the shared master workflow but never passed
DTRACK_API_KEY. InEyeSeeTea/github-workflows/.github/workflows/master.yml,dtrack-prerequisitessetsenabled=falsewhen the secret is empty, and bothdependency-track-yarn4anddependency-track-syftare gated on it. They are therefore skipped, and the workflow still reports success. Verified on run #32725139080: both jobsskipped, run green.This PR passes the secret through so the repository is actually scanned.
Expected outcome of this PR
masterhas never been scanned, so there is no base analysis to compare against. The gate computes the introduced set as head-alerts minus base-alerts and will attribute the entire pre-existing backlog to this branch.report_open_code_scanning_alert_instances.shdoes export abaseline_missingflag, but the gate step independency-track-yarn4.ymlreads onlyintroduced_*_count, so nothing consumes it.