Repository navigation
fix(windows): persist installation in system path - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows installation registered only the user PATH and left the current PowerShell session unable to find
mdo. Install the executable underProgram Files\mdo, require administrator privileges, and register the directory in both the persistent system PATH and the current session.Preserve existing PATH entries, avoid duplicates on reinstallation, and stop on installation errors before reporting success. Document administrator access, the script directory and a session-only execution policy override. Add installer regression tests to CI for Windows PowerShell 5.1 and PowerShell 7.
Validation: CI passed, including native installer regression tests in Windows PowerShell 5.1 and PowerShell 7, Go tests, the race detector and the build. Windows tests verify persistent system PATH registration, current-session command priority, reinstallation without duplicates, empty PATH handling and failure behavior.