Skip to content

Rewrite ControlGlobalSave - #3435

Merged
carstene1ns merged 2 commits into
EasyRPG:masterfrom
Ghabry:maniac-control-global-save
Jul 25, 2025
Merged

Rewrite ControlGlobalSave#3435
carstene1ns merged 2 commits into
EasyRPG:masterfrom
Ghabry:maniac-control-global-save

Conversation

@Ghabry

@Ghabry Ghabry commented Jun 16, 2025

Copy link
Copy Markdown
Member

Main difference is the logic when opening the save. Also moved it to ManiacPatch file to reduce complexity in the interpreter code.

Header cleanup (was necessary because of weird compile errors due to a Game_String include while moving code around)

Fix #3069


@Mimigris please test this. Should be at least closer than before xD

@Mimigris

Copy link
Copy Markdown
Contributor

Sorry for answering a bit late on this, just started my testing.

From what I can see, the Save.lgs file is not able to be created at the moment using the build of this pull request, only updated, meaning that storing data in a Save.lgs file is impossible unless said file already existed, so this would probably need to be fixed before doing bigger testings due to being at the heart of the command.

Main difference is the logic when opening the save.
Also moved it to ManiacPatch file to reduce complexity in the interpreter code.

Header cleanup (was necessary because of weird compile errors due to a Game_String include while moving code around)

Fix EasyRPG#3069
@Ghabry
Ghabry force-pushed the maniac-control-global-save branch from 9e4dd68 to 3f58fb8 Compare June 23, 2025 14:25
@Ghabry

Ghabry commented Jun 23, 2025

Copy link
Copy Markdown
Member Author

Yeah my bad, the flag that tracked whether the global save is "opened" what only set when the file exists... Is fixed now

@Mimigris

Mimigris commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Noticed a crash with the current setup.
I have the Player set outside of a game folder, and I use it to open a folder containing the game (game in question being the EasyRPG TestGame made for Maniac).
If I use the command Open Global Save in the command, then exit it, then make the program close by exiting the game browser, the Player will crash instead of closing as intended.

@Ghabry

Ghabry commented Jun 28, 2025

Copy link
Copy Markdown
Member Author

ResetGameObjects was not called when doing it as you described.

I added this call now to Continue from the game browser. No idea why this wasn't used before, seems to work fine (likely some other bugfix before).

@Mimigris

Copy link
Copy Markdown
Contributor

Outside of the last point mentioned in #3069 , which has been explained in chat why it has not been adressed (tied to the path cache + not something that would be noticeable while playing normally), everything seems good from what I see 👍

@Ghabry
Ghabry marked this pull request as ready for review June 29, 2025 22:53
@carstene1ns
carstene1ns merged commit 8d761b8 into EasyRPG:master Jul 25, 2025
@Ghabry Ghabry added this to the 0.8.2 milestone Jul 25, 2025
sevenc-nanashi pushed a commit to sevenc-nanashi/easyrpg-player that referenced this pull request May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Maniac: Global Save - Several issues

3 participants