fix: wait for local recent note restoration - #117
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
A failed snapshot refetch can indefinitely block opening a note already present in cached Local Vault data.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates recent-note restoration to wait for the active workspace鈥檚 data, including Local Vault snapshots.
Changes:
- Adds workspace-aware loading and scope matching.
- Switches to Local Vault before restoring local recent notes.
- Adds unit and integration coverage.
| File | Description |
|---|---|
src/鈥媝ages/鈥婬ome.tsx |
Supplies workspace-specific query state. |
src/鈥媝ages/鈥婬ome.test.tsx |
Tests deferred Local Vault restoration. |
src/鈥媝ages/鈥媏lectron-home/鈥媢seWorkbenchQuickOpen.ts |
Routes local recent notes to Local Vault. |
src/鈥媝ages/鈥媏lectron-home/鈥媢seWorkbenchQuickOpen.test.tsx |
Tests Local Vault routing. |
src/鈥媝ages/鈥媏lectron-home/鈥媢sePendingRecentNoteRestore.ts |
Adds workspace-aware restoration. |
src/鈥媝ages/鈥媏lectron-home/鈥媢sePendingRecentNoteRestore.test.tsx |
Tests snapshot waiting behavior. |
src/鈥媝ages/鈥媏lectron-home/鈥媢seElectronHomeCommandPalette.ts |
Propagates workspace query state. |
src/鈥媝ages/鈥媏lectron-home/鈥媢seElectronHomeCommandPalette.test.tsx |
Updates command-palette test options. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for the active workspace data before deciding that a recent note is missing. Local Vault recent notes now switch to Local Vault, wait for its snapshot, and open after it loads instead of being treated as HackMD team notes.
Closes #103
Validation:
pnpm checknpx -y react-doctor@latest --verbose --scope changed(92/100; existing Home complexity warning)