fix: reconcile keyboard note saves - #115
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
The focused implementation matches the existing Save-button path and includes regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns keyboard note saves with button saves so Local Vault drafts reconcile correctly.
Changes:
- Passes active tab and submitted draft metadata during keyboard saves.
- Adds regression coverage for Local Vault reconciliation.
| File | Description |
|---|---|
src/鈥媝ages/鈥婬ome.tsx |
Routes keyboard saves through draft reconciliation. |
src/鈥媝ages/鈥婬ome.test.tsx |
Tests Local Vault keyboard-save behavior. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Cmd/Ctrl+S so it passes the active tab and submitted draft through the same reconciliation path as the Save button. This prevents Local Vault saves from leaving a stale draft revision and showing an incorrect disk-change recovery state.
Closes #101
Validation:
pnpm checknpx -y react-doctor@latest --verbose --scope changed(92/100; existing Home complexity warning)