Add a check that GLC has the coarsest coupling frequency - #694
Merged
Conversation
This was implicitly assumed but not checked. Resolves ESCOMP#688
Member
Author
|
@mvertens - FYI (but I know you won't be able to review this before we merge it) |
ekluzek
approved these changes
Aug 15, 2026
ekluzek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I really like having this checked so that the model doesn't crash when it's done accidentally.
Thanks for bringing this in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This was implicitly assumed but not checked.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) bfb
Any User Interface Changes (namelist or namelist defaults changes)? no
Testing performed
Just tested namelist generation, since this branch just adds error checking at namelist-generation time, and doesn't change any other behavior.
(1) Created case SMS_Ld2.ne30pg3_t232.B1850C_LTso.green_gnu - confirmed that no error is generated at preview_namelists time
(2) In that test, changed GLC_NCPL=8 (matching ROF_NCPL) - confirmed that no error is generated at preview_namelists time (though there is a duplicate
@10800loop; this is okay as noted below)(3) In that test, changed GLC_NCPL=24 - confirmed that an error IS generated
(4) Created an F compset test
SMS.ne30pg3_t232.HIST_CAM60_CLM50%SP_CICE%PRES_DOCN%DOM_MOSART_DGLC%NOEVOLVE_SWAV_SESP.green_gnu- confirmed that no error is generated at preview_namelists time(5) Created an I compset test
SMS.ne30pg3_t232.HIST_DATM%GSWP3v1_CLM50%SP_SICE_SOCN_MOSART_DGLC%NOEVOLVE_SWAV_SESP.green_gnu- confirmed that no error is generated at preview_namelists time(6) Confirmed that it is okay to have two loops with the same time frequency (as suggested by @mvertens ): Ran test
SMS_Ld2.ne30pg3_t232.B1850C_LTso.derecho_intel.allactive-defaultiowhere I changed GLC_NCPL=8. Compared (a) a version with the auto-generated nuopc.runseq against (b) a version where I made this change:Both tests pass and are bit-for-bit with each other.