fix(cmeps): Move CALENDAR to env_run.xml and add lock_on_restart="true" - #692
Closed
johnpaulalex wants to merge 1 commit into
Closed
fix(cmeps): Move CALENDAR to env_run.xml and add lock_on_restart="true"#692johnpaulalex wants to merge 1 commit into
johnpaulalex wants to merge 1 commit into
Conversation
Member
|
Sorry, I just realized I never approved #685 . I just approved that now. My suggestion is that we first bring in that PR as is (i.e., without the lock_on_restart attribute). Then we need some discussion in CIME (ESMCI/cime#5030) about this new lock_on_restart feature. If that's approved, then this attribute could be added to CALENDAR and others later. @johnpaulalex - how does that sound to you? |
Member
|
Closing based on above discussion. |
Contributor
Author
|
Note this issue is now tracked in ESMCI/cime#5040. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Moves
CALENDARvariable definition fromenv_build.xml(groupbuild_def) toenv_run.xml(grouprun_begin_stop_restart), aligning its XML group with runtime initialization variables likeRUN_TYPEandRUN_STARTDATE. Addslock_on_restart="true"attribute to prevent modifying the calendar type on continuation runs (CONTINUE_RUN=TRUE). Also fixes a typo innamelist_definition_drv.xmldocumentation reference.Parent PR: #5030 (Base branch:
feature/lock-on-restartonESMCI/cime)Specific notes
Contributors other than yourself, if any: None
Linked issues addressed, if any: Resolves ESCOMP/CTSM#4122
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial):
Bit-for-bit (B4B).
Any User Interface Changes (namelist or namelist defaults changes)?
Moves
CALENDARvariable fromenv_build.xmltoenv_run.xmlunder grouprun_begin_stop_restart.Testing performed
xmllintagainstCIME/data/config/xml_schemas/entry_id.xsd.CALENDARparameter move and locking functionality in case setup and continuation run tests.Generative AI usage:
Google Antigravity was used to write the code and tests, followed by human-guided verification.