Skip to content

fix(cmeps): Move CALENDAR to env_run.xml and add lock_on_restart="true" - #692

Closed
johnpaulalex wants to merge 1 commit into
ESCOMP:mainfrom
johnpaulalex:fix/calendar-4122-cmeps-new
Closed

fix(cmeps): Move CALENDAR to env_run.xml and add lock_on_restart="true"#692
johnpaulalex wants to merge 1 commit into
ESCOMP:mainfrom
johnpaulalex:fix/calendar-4122-cmeps-new

Conversation

@johnpaulalex

@johnpaulalex johnpaulalex commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Moves CALENDAR variable definition from env_build.xml (group build_def) to env_run.xml (group run_begin_stop_restart), aligning its XML group with runtime initialization variables like RUN_TYPE and RUN_STARTDATE. Adds lock_on_restart="true" attribute to prevent modifying the calendar type on continuation runs (CONTINUE_RUN=TRUE). Also fixes a typo in namelist_definition_drv.xml documentation reference.

Parent PR: #5030 (Base branch: feature/lock-on-restart on ESMCI/cime)

Specific notes

Contributors other than yourself, if any: None

Linked issues addressed, if any: Resolves ESCOMP/CTSM#4122

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial):
Bit-for-bit (B4B).

Any User Interface Changes (namelist or namelist defaults changes)?
Moves CALENDAR variable from env_build.xml to env_run.xml under group run_begin_stop_restart.

Testing performed

  • Tested XML schema validation using xmllint against CIME/data/config/xml_schemas/entry_id.xsd.
  • Verified CALENDAR parameter move and locking functionality in case setup and continuation run tests.

Generative AI usage:

Google Antigravity was used to write the code and tests, followed by human-guided verification.

@billsacks

Copy link
Copy Markdown
Member

Sorry, I just realized I never approved #685 . I just approved that now. My suggestion is that we first bring in that PR as is (i.e., without the lock_on_restart attribute). Then we need some discussion in CIME (ESMCI/cime#5030) about this new lock_on_restart feature. If that's approved, then this attribute could be added to CALENDAR and others later.

@johnpaulalex - how does that sound to you?

@billsacks

Copy link
Copy Markdown
Member

Closing based on above discussion.

@billsacks billsacks closed this Aug 14, 2026
@johnpaulalex

Copy link
Copy Markdown
Contributor Author

Note this issue is now tracked in ESMCI/cime#5040.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

env_build.xml cannot be changed via usermods if keepexe is an option (triggered by changing CALENDAR in a cloned PLUMBER2 site)

2 participants