[gitlab] Add GitLab support for bot: show_config command - #390
Open
sondrebr wants to merge 6 commits into
Open
Conversation
Fall back to `GitHubEventInfo.issue_number` for `issue_comment` events
Use `event_info` instead
Use `event_info` instead
pull_request labeled and closed events are also "working" for GL but not actually supported: For closed events, the bot responds with a '... not yet supported' message; For labeled events, the bot responds with a '... not yet supported' message if the label is 'bot:deploy'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds GitLab support for the
bot: show_configcommand. As part of this, the following changes were also made:pull_requestevent handling added for GitLab:prremoved as parameter ofhandle_pull_request_*_event()methods anddeploy_built_artefacts()handle_merge_request_event = handle_pull_request_eventhandle_pull_request_opened_event()is properly implemented for GitLabhandle_pull_request_labeled_event()makes the bot post a "... not yet supported ..." message on GitLab when abot:deploylabel is addedhandle_pull_request_closed_event()makes the bot post a "... not yet supported ..." message on GitLab (if the bot is configured to be chatty)EventInfochanges:pr_titleproperty added (+ tests)pr_numberfalls back toissue_numberforissue_commentevents on GitHubshow_configcommand supportThe PR is ready for review, but it should only be merged after #387 has been merged.