Repository navigation
feat: add unity_recompile and published Editor state to Attach, and bundle window capture and camera render scripts - #15
Merged
Conversation
…undle window capture and camera render scripts
Comment on lines
+130
to
+131
| $"Compilation {result["sequence"]} is still {result["phase"]}. Do not request it again; " + | ||
| "watch status until the latest compilation sequence is greater than this one.", element, watch); |
There was a problem hiding this comment.
🔴 Wait for completion and recovery, not just a newer sequence
RecompileWait returns the pre-request baseline sequence on timeout, while Bridge.BeginCompile() increments and publishes the sequence when compilation starts. Therefore the stated stop condition can already be satisfied while compilation is still running, or while its Domain Reload is pending. Agents following this instruction can proceed before the new scripts are usable. Require a finished record, inspect its outcome, and verify settling/reload recovery; update the matching timeout instructions in references/cli.md and references/compilation-and-reload.md too.
Suggested change
| $"Compilation {result["sequence"]} is still {result["phase"]}. Do not request it again; " + | |
| "watch status until the latest compilation sequence is greater than this one.", element, watch); | |
| $"Recompilation is still {result["phase"]} (baseline sequence {result["sequence"]}). Do not request it again; " + | |
| "watch status for a newer finished compilation, check its succeeded result, and verify that the Editor " + | |
| "has settled and any Domain Reload has recovered before continuing.", element, watch); |
… bridge was not recovered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unity_recompileto the Attach CLI (dotcraft-unity recompile) and MCP. It sends one compile request and waits for that compilation and the Domain Reload after it, so agents no longer pollisCompiling.statusnow shows the Editor state the bridge last published (compile result, play mode, connection) without injecting.