Skip to content

feat: add unity_recompile and published Editor state to Attach, and bundle window capture and camera render scripts - #15

Merged
AkiKurisu merged 2 commits into
masterfrom
feat/attach-recompile
Oct 26, 2026
Merged

AkiKurisu merged 2 commits into
masterfrom
feat/attach-recompile

Conversation

@AkiKurisu

Copy link
Copy Markdown
Member

Summary

  • Add unity_recompile to the Attach CLI (dotcraft-unity recompile) and MCP. It sends one compile request and waits for that compilation and the Domain Reload after it, so agents no longer poll isCompiling.
  • Attach status now shows the Editor state the bridge last published (compile result, play mode, connection) without injecting.
  • Bundle window capture, pane rect and camera render as skill scripts, and trim the references that embedded that code.

…undle window capture and camera render scripts

@oratorio-integration oratorio-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues.

Comment on lines +130 to +131
$"Compilation {result["sequence"]} is still {result["phase"]}. Do not request it again; " +
"watch status until the latest compilation sequence is greater than this one.", element, watch);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Wait for completion and recovery, not just a newer sequence

RecompileWait returns the pre-request baseline sequence on timeout, while Bridge.BeginCompile() increments and publishes the sequence when compilation starts. Therefore the stated stop condition can already be satisfied while compilation is still running, or while its Domain Reload is pending. Agents following this instruction can proceed before the new scripts are usable. Require a finished record, inspect its outcome, and verify settling/reload recovery; update the matching timeout instructions in references/cli.md and references/compilation-and-reload.md too.

Suggested change
$"Compilation {result["sequence"]} is still {result["phase"]}. Do not request it again; " +
"watch status until the latest compilation sequence is greater than this one.", element, watch);
$"Recompilation is still {result["phase"]} (baseline sequence {result["sequence"]}). Do not request it again; " +
"watch status for a newer finished compilation, check its succeeded result, and verify that the Editor " +
"has settled and any Domain Reload has recovered before continuing.", element, watch);

@oratorio-integration oratorio-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@AkiKurisu
AkiKurisu merged commit c9cad1c into master Oct 26, 2026
5 checks passed
@AkiKurisu
AkiKurisu deleted the feat/attach-recompile branch October 26, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant