wpt: use wpt-runner-types crate for META and fuzzy parsing - #818
Draft
nicoburns wants to merge 1 commit into
Draft
wpt: use wpt-runner-types crate for META and fuzzy parsing#818nicoburns wants to merge 1 commit into
nicoburns wants to merge 1 commit into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the WPT runner to the new
wpt-runner-typescrate (nicoburns/wpt-rs#4), which upstreams the// META:comment parsing and reftest fuzziness parsing with more rigour:js_wrapper.rsnow consumesparse_script_metadata()/ScriptMetadata(typed directives incl.globalasGlobalScopewith upstream's full keyword set andworker/shadowrealmlonghand expansion).js_test_has_window_variantis nowglobal_scopes().contains(&GlobalScope::Window)— note this also matches upstream's default of{window, dedicatedworker}when noglobal=is present.fuzzy.rskeeps only the HTML<meta name=fuzzy>scraping and the RGBA buffer diff; the content-value parsing (FuzzySpec: FromStrwith structured errors,tolerance_for_reference) moves upstream. The new parser is stricter (rejects unknown/duplicate properties and wrong part counts like upstream's manifest code) and additionally supports named args in either order.Draft until nicoburns/wpt-rs#4 merges and
wpt-runner-typesis published — currently pinned as a git dependency (rev = 961f8b9); should be switched to a crates.io version before merging.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/13db5150cbcd480b86567637ec411a82
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/13db5150cbcd480b86567637ec411a82?variant=devin-insiders
Requested by: @nicoburns
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.