Skip to content

wpt: use wpt-runner-types crate for META and fuzzy parsing - #818

Draft
nicoburns wants to merge 1 commit into
mainfrom
devin/1788211920-use-wpt-runner-types
Draft

wpt: use wpt-runner-types crate for META and fuzzy parsing#818
nicoburns wants to merge 1 commit into
mainfrom
devin/1788211920-use-wpt-runner-types

Conversation

@nicoburns

@nicoburns nicoburns commented Aug 31, 2026

Copy link
Copy Markdown
Member

Summary

Switches the WPT runner to the new wpt-runner-types crate (nicoburns/wpt-rs#4), which upstreams the // META: comment parsing and reftest fuzziness parsing with more rigour:

  • js_wrapper.rs now consumes parse_script_metadata() / ScriptMetadata (typed directives incl. global as GlobalScope with upstream's full keyword set and worker/shadowrealm longhand expansion). js_test_has_window_variant is now global_scopes().contains(&GlobalScope::Window) — note this also matches upstream's default of {window, dedicatedworker} when no global= is present.
  • fuzzy.rs keeps only the HTML <meta name=fuzzy> scraping and the RGBA buffer diff; the content-value parsing (FuzzySpec: FromStr with structured errors, tolerance_for_reference) moves upstream. The new parser is stricter (rejects unknown/duplicate properties and wrong part counts like upstream's manifest code) and additionally supports named args in either order.

Draft until nicoburns/wpt-rs#4 merges and wpt-runner-types is published — currently pinned as a git dependency (rev = 961f8b9); should be switched to a crates.io version before merging.

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/13db5150cbcd480b86567637ec411a82
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/13db5150cbcd480b86567637ec411a82?variant=devin-insiders
Requested by: @nicoburns

WPT results

No changes in test results compared to main.

Generated by the WPT workflow.

@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant