Box the per-node transform to shrink ElementData - #796
Open
nicoburns wants to merge 3 commits into
Open
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This was referenced Aug 25, 2026
staging-devin-ai-integration
Bot
force-pushed
the
devin/1787687735-box-node-transform
branch
from
August 26, 2026 01:05
bf57e53 to
9e1ef0f
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1787687735-box-node-transform
branch
from
August 26, 2026 01:09
df577fd to
c0b405a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ElementData/DocumentData::transformbecomesOption<Box<Affine>>instead ofOption<Affine>.Affineis[f64; 6](48 bytes) with no niche, so the inlineOption<Affine>cost 56 bytes on every element even though the vast majority of elements have no CSS transform; boxed it costs 8 bytes (pointer niche), with a heap allocation only for the rare transformed nodes.Measured with a size_of probe:
ElementDatadrops 1472 → 1424 bytes onmain(heap profiling of the Barack Obama Wikipedia page showed ~22.8k elements at the 1536-byte malloc size class dominating the Document heap). Note the standalone win is struct-size only — 1424 still rounds to the same 1536-byte malloc class; it compounds with #794 (which removes the 488-byte ownedtaffy::Style) and any futureCacheshrinking.Callers adjusted for the extra indirection:
Node::set_transformstill computes and returnsOption<Affine>by value; only the stored field is boxed (transform.map(Box::new)).Testing
cargo clippy --workspace --all-targetsandcargo fmt --all --checkpass (one pre-existingclone_on_copywarning inexamples/custom_widget.rsunrelated to this change).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/9cffd370ef03474e88a93f5335b19b65
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/9cffd370ef03474e88a93f5335b19b65?variant=devin-insiders
Requested by: @nicoburns
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.