Skip to content

Upgrade taffy for last-baseline support - #721

Open
nicoburns wants to merge 2 commits into
mainfrom
devin/1786754807-taffy-last-baseline
Open

Upgrade taffy for last-baseline support#721
nicoburns wants to merge 2 commits into
mainfrom
devin/1786754807-taffy-last-baseline

Conversation

@nicoburns

@nicoburns nicoburns commented Aug 15, 2026

Copy link
Copy Markdown
Member

Summary

Bumps taffy to the tip of taffy#1113 (bb30dbf2, top of the stacked series #1110 → #1111 → #1113, which includes latest taffy main) and adapts Blitz to the new last-baseline APIs:

  • Inline layout now reports both first and last Parley line baselines via LayoutOutput::baselines: Baselines { first, last } (previously only the first, via Baselines::from_first).
  • stylo::AlignFlags::LAST_BASELINE now maps to the real taffy::AlignItems::LAST_BASELINE instead of falling back to END.

Rebased on main, which already includes the Baselines type and scrollable_overflow_rect migrations (#733), so the diff is now just the rev bump plus the two behavioral changes above.

Should merge only after the taffy stack lands; the rev should ideally then be bumped to the merge commit.

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/c0a80d9344d54e918b37cacfb71a2128
Requested by: @nicoburns

WPT results

12 newly passing, 0 newly failing (net +12).

Full diff (12 changed tests)
+ Fail => Pass css/css-flexbox/alignment/flex-align-baseline-flex-003.html
+ Fail => Pass css/css-flexbox/alignment/flex-align-baseline-overflow-001.html
+ Fail => Pass css/css-flexbox/flexbox-align-self-baseline-horiz-007.xhtml
+ Fail => Pass css/css-grid/alignment/grid-align-baseline-004.html
+ Fail => Pass css/css-grid/alignment/grid-align-baseline-flex-003.html
+ Fail => Pass css/css-grid/alignment/grid-align-baseline-overflow-001.html
+ Fail => Pass css/css-grid/alignment/grid-self-alignment-baseline-with-grid-001.html
+ Fail => Pass css/css-grid/alignment/grid-self-alignment-baseline-with-grid-002.html
+ Fail => Pass css/css-grid/alignment/grid-self-alignment-baseline-with-grid-003.html
+ Fail => Pass css/css-grid/alignment/grid-self-alignment-baseline-with-grid-004.html
+ Fail => Pass css/css-grid/alignment/self-baseline/grid-self-baseline-008.html
+ Fail => Pass css/css-grid/subgrid/subgrid-baseline-011.html

Generated by the WPT workflow.

@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1786754807-taffy-last-baseline branch from 6b1969a to a52a3ac Compare August 18, 2026 19:06
@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1786754807-taffy-last-baseline branch 2 times, most recently from e524553 to 3c07d0e Compare August 19, 2026 12:03
@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1786754807-taffy-last-baseline branch from 3c07d0e to 3ff28f0 Compare August 21, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant