Fix devIocStats by including posix headers - #134
Merged
Merged
Conversation
AlexanderWells-diamond
force-pushed
the
fix_deviocstats
branch
from
June 7, 2023 15:10
ec2c1df to
40dfcfa
Compare
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 14 14
Lines 996 996
=======================================
Hits 871 871
Misses 125 125 |
coretl
approved these changes
Jun 8, 2023
coretl
left a comment
coretl
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for doing this
This relies on the config_var "POSIX" being defined as True/False for the current platform. The test is pretty simple, just the CPU count and IOC CPU load as they're fairly easy to calculate
AlexanderWells-diamond
force-pushed
the
fix_deviocstats
branch
from
June 8, 2023 08:23
40dfcfa to
c826477
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relies on the config_var "POSIX" being defined as True/False for the current platform.
The test is pretty simple, just the CPU count and IOC CPU load as they're fairly easy to calculate
Fixes #131