Repository navigation
Move i15_1.py from using device_factory to using DeviceManager - #1890
Merged
Merged
Conversation
Mark-Booth
force-pushed
the
dodal-1882
branch
from
February 5, 2026 10:46
4f3b836 to
83a8c17
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1890 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 304 304
Lines 11508 11509 +1
=======================================
+ Hits 11410 11411 +1
Misses 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
approved these changes
Feb 5, 2026
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Great, thank you! Some notes for future PRs:
- The PR title will be automatically used for release notes (https://github.com/DiamondLightSource/dodal/releases/tag/2.0.0). I think this title is fine but I would usually remove the
#1882bit at the beginning as it IMO makes the notes less readable - It's a good habit to fill in the
Instructions to reviewer on how to test:section on the PR. It gives other people in the wider DAQ team a fighting chance at reviewing it. In this case I would have written something like "Confirmdodal connect i15-1works on main and on here and there are the same number of devices on both
Both nice to haves though, I'll change the title and merge for you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1882
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}