Skip to content

Move i15_1.py from using device_factory to using DeviceManager - #1890

Merged
DominicOram merged 2 commits into
mainfrom
dodal-1882
Feb 5, 2026
Merged

DominicOram merged 2 commits into
mainfrom
dodal-1882

Conversation

@Mark-Booth

Copy link
Copy Markdown
Member

Fixes #1882

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Mark-Booth
Mark-Booth requested a review from a team as a code owner February 5, 2026 10:29
@codecov

codecov Bot commented Feb 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (9637758) to head (920218d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1890   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         304      304           
  Lines       11508    11509    +1     
=======================================
+ Hits        11410    11411    +1     
  Misses         98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! Some notes for future PRs:

  • The PR title will be automatically used for release notes (https://github.com/DiamondLightSource/dodal/releases/tag/2.0.0). I think this title is fine but I would usually remove the #1882 bit at the beginning as it IMO makes the notes less readable
  • It's a good habit to fill in the Instructions to reviewer on how to test: section on the PR. It gives other people in the wider DAQ team a fighting chance at reviewing it. In this case I would have written something like "Confirm dodal connect i15-1 works on main and on here and there are the same number of devices on both

Both nice to haves though, I'll change the title and merge for you

@DominicOram DominicOram changed the title #1882 Move i15_1.py from using device_factory to using DeviceManager Move i15_1.py from using device_factory to using DeviceManager Feb 5, 2026
@DominicOram
DominicOram enabled auto-merge (squash) February 5, 2026 14:47
@DominicOram
DominicOram merged commit 83243e8 into main Feb 5, 2026
7 checks passed
@DominicOram
DominicOram deleted the dodal-1882 branch February 5, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move i15_1.py from device_factory to DeviceManager

2 participants