Skip to content

add http basic auth for X-Pack plugin - #32

Open
tanhaipeng wants to merge 1 commit into
DhavalKapil:masterfrom
tanhaipeng:master
Open

add http basic auth for X-Pack plugin#32
tanhaipeng wants to merge 1 commit into
DhavalKapil:masterfrom
tanhaipeng:master

Conversation

@tanhaipeng

@tanhaipeng tanhaipeng commented Oct 12, 2018

Copy link
Copy Markdown

fix #29

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-3.6%) to 87.126% when pulling 692b5fb on tanhaipeng:master into 490f6b2 on DhavalKapil:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-3.6%) to 87.126% when pulling 692b5fb on tanhaipeng:master into 490f6b2 on DhavalKapil:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-3.6%) to 87.126% when pulling 692b5fb on tanhaipeng:master into 490f6b2 on DhavalKapil:master.

@tanhaipeng

tanhaipeng commented Oct 12, 2018

Copy link
Copy Markdown
Author

Check how your Lua installation was built. lua_objlen is only available if you compile Lua with certain compatibility flags: https://www.lua.org/source/5.3/luaconf.h.html
It was renamed to lua_rawlen in 5.2.
You need to rebuild with -DLUA_COMPAT_5_1

lua 5.2 CI run failed

@neilcook

neilcook commented Nov 2, 2018

Copy link
Copy Markdown
Collaborator

I'll look at the cjson issue separately, it's a pita TBH. I'll have to build lua manually in travis rather than use the built-in lua.

Check how your Lua installation was built. lua_objlen is only available if you compile Lua with certain compatibility flags: https://www.lua.org/source/5.3/luaconf.h.html
It was renamed to lua_rawlen in 5.2.
You need to rebuild with -DLUA_COMPAT_5_1

lua 5.2 CI run failed

@neilcook

neilcook commented Nov 2, 2018

Copy link
Copy Markdown
Collaborator

If you can add some tests for the authentication code I'd be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add user/password for elastic 5.5.1 X-Pack

3 participants