Skip to content

chore: Make FontAwesome CDN URL configurable via environment variable #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Strehk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Make FontAwesome CDN URL configurable via environment variable #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92f72fe
feat (config): make FontAwesome CDN base URL configurable via env
claude Jul 5, 2026
70092b6
fix (deps): upgrade nodemailer to ^9.0.1 to resolve GHSA-p6gq-j5cr-w38f
claude Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,12 @@ PUBLIC_FEEDBACK_URL=https://fb-delegator.dmun.de
# When set, shows a warning when inviting emails from other domains
# PUBLIC_TEAM_ORGANIZATION_DOMAIN=dmun.de

# [REQUIRED] Base URL for the FontAwesome CSS files (without trailing slash)
# The app loads <base>/fontawesome.min.css, <base>/solid.min.css,
# <base>/duotone.min.css and <base>/brands.min.css from this location.
# Change this if the FontAwesome CDN moves.
PUBLIC_FONTAWESOME_CSS_BASE_URL=https://cdn.dmun.de/cdn/fontawesome-pro-6.7.2/css

# ───────────────────────────────────────────────────────────────────────────────
# CERTIFICATES
# ───────────────────────────────────────────────────────────────────────────────
Expand Down
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"dependencies": {
"diff-match-patch": "^1.0.5",
"humanparser": "^2.7.0",
"nodemailer": "^7.0.11",
"nodemailer": "^9.0.1",
"typst": "^0.10.0-8"
},
"devDependencies": {
Expand Down
17 changes: 4 additions & 13 deletions src/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,10 @@
<head>
<meta charset="utf-8" />
<link rel="icon" href="%sveltekit.assets%/favicon.png" />
<link
rel="stylesheet"
href="https://cdn.dmun.de/cdn/fontawesome-pro-6.7.2/css/fontawesome.min.css"
/>
<link rel="stylesheet" href="https://cdn.dmun.de/cdn/fontawesome-pro-6.7.2/css/solid.min.css" />
<link
rel="stylesheet"
href="https://cdn.dmun.de/cdn/fontawesome-pro-6.7.2/css/duotone.min.css"
/>
<link
rel="stylesheet"
href="https://cdn.dmun.de/cdn/fontawesome-pro-6.7.2/css/brands.min.css"
/>
<link rel="stylesheet" href="%fontawesome.baseUrl%/fontawesome.min.css" />
<link rel="stylesheet" href="%fontawesome.baseUrl%/solid.min.css" />
<link rel="stylesheet" href="%fontawesome.baseUrl%/duotone.min.css" />
<link rel="stylesheet" href="%fontawesome.baseUrl%/brands.min.css" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
%sveltekit.head%
</head>
Expand Down
4 changes: 4 additions & 0 deletions src/config/public.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ const schema = z.object({
PUBLIC_FEEDBACK_URL: z.optional(z.string()),
PUBLIC_GLOBAL_USER_NOTES_ACTIVE: z.coerce.boolean().default(false),

// Base URL for the FontAwesome CSS files (without trailing slash).
// The app loads `<base>/fontawesome.min.css`, `<base>/solid.min.css`, etc. from here.
PUBLIC_FONTAWESOME_CSS_BASE_URL: z.string(),

// --- TEMPORARY: Migration notice (remove after migration period) ---
PUBLIC_OIDC_MIGRATION_NOTICE: z.coerce.boolean().default(false),

Expand Down
5 changes: 4 additions & 1 deletion src/hooks.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { sequence } from '@sveltejs/kit/hooks';
import { paraglideMiddleware } from '$lib/paraglide/server';
import { building } from '$app/environment';
import { configPrivate } from '$config/private';
import { configPublic } from '$config/public';

// Initialize Sentry (only if DSN provided and not building)
if (!building && configPrivate.SENTRY_DSN) {
Expand All @@ -21,7 +22,9 @@ const paraglideHandle: Handle = ({ event, resolve }) =>
event.request = localizedRequest;
return resolve(event, {
transformPageChunk: ({ html }) => {
return html.replace('%lang%', locale);
return html
.replace('%lang%', locale)
.replaceAll('%fontawesome.baseUrl%', configPublic.PUBLIC_FONTAWESOME_CSS_BASE_URL);
},
// Houdini's fetch plugin reads the content-type header from responses
// fetched during SSR load; SvelteKit only serializes headers that pass
Expand Down
Loading