Cleaner OTEL Implementation - #354
Merged
Merged
Conversation
Register W3C propagator and propagate active OpenTelemetry context in GraphQL tracer so spans are correctly parented (fixes Jaeger showing single-line spans). Add Jaeger service and persistent volume to dev.docker-compose.yml and assign composable profiles to services so observability stack can be enabled separately. Update package.json to provide convenient docker-compose scripts for core, listmonk, observability and full setups.
Ensure the OpenTelemetry tracer is initialized before any other imports to allow HttpInstrumentation to patch HTTP modules correctly. Add an import of the tracer in hooks.server so tracing starts first, and import the SvelteKit build-time "building" flag into tracer to enable environment-aware behavior when exporting spans.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Update tracer setup to register a single span processor instead of always adding the fallback first and then conditionally adding the active processor. Now the provider adds only the active processor (OTLP or console fallback), avoiding duplicate processors and ensuring a single, intended processor handles spans. This simplifies logic and prevents potential double-processing of spans.
m1212e
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
Notes
This is part 2 of 2 in a stack made with GitButler: