Repository navigation
Improve copying when the clipboard is blocked, and credit a contributor - #52
Merged
Gabriel Mongefranco (gabrielmongefranco) merged 2 commits intoOct 27, 2026
Merged
Conversation
When the browser refuses to copy, the popup now says so directly and tells people to press Ctrl+C (Cmd+C on a Mac), since the text is already selected. The popup now shows one Done button instead of Done and Close buttons that did the same thing. The question popup has a new hideCancel option for this, and the hidden button is also disabled so keyboard focus skips it. Also add @NehonaYa to the contributors list in the README.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Some pages block the browser's clipboard feature or don't offer it at all, such as pages opened over plain http. The browser's older copy command often still works there. Copy buttons now try that command, using a hidden text box that is removed right away, before they show the popup for copying by hand. Keyboard focus then goes back to the control that started the copy if it is still on the page. The question popup also checks that the control it returns focus to is still on the page. New tests cover a clipboard feature that exists but can't be used, the older copy command working and failing, and a control that is removed before the copy finishes. docs/compliance.md describes the new step.
4 tasks
Gabriel Mongefranco (gabrielmongefranco)
merged commit Oct 27, 2026
2b23098
into
main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on #51, which added a popup for copying text by hand when the browser refuses to copy.
Changes
document.execCommand('copy')) often still works there. Copy buttons now try it, using a hidden text box that is removed right away, before they show the popup. Fewer people should see the popup as a result. Browsers have deprecated this command, but all major browsers still support it, and the popup is still there if it fails.dlvAskDialog) makes the same check.hideCanceloption for this. The hidden button is also disabled, so pressing Tab skips it. The other questions that use the popup still show both buttons.docs/compliance.mddescribes the new copy step.Testing
node --test tests/). The new tests cover these cases: