Skip to content

Fix red koopa shell homing without an owner #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hugman76 merged 1 commit into from
Aug 25, 2026
Merged

Fix red koopa shell homing without an owner #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...rio/src/main/java/fr/hugman/mubble/super_mario/world/entity/projectile/RedKoopaShell.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import net.minecraft.resources.Identifier;
import net.minecraft.server.level.ServerLevel;
import net.minecraft.util.Mth;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.EntityType;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.entity.ai.targeting.TargetingConditions;
Expand Down Expand Up @@ -160,17 +159,19 @@ private LivingEntity findTarget() {
if (!(this.level() instanceof ServerLevel serverLevel)) {
return null;
}
// an owner-less shell, thrown by a dispenser for instance, still homes in: it just has no one to spare
Entity owner = this.getOwner();
// a shell nobody threw has no one to home in on behalf of, so it never looks for a target at all
if (!(this.getOwner() instanceof LivingEntity livingOwner)) {
return null;
}
// the search box is a cube, so its corners reach further than the shell is willing to home in from:
// filtering on the same conditions the target is later kept on avoids locking onto one of those, only
// to drop it on the very next tick
var candidates = serverLevel.getEntitiesOfClass(LivingEntity.class, this.getSearchBox(MAX_TARGET_DISTANCE),
candidate -> candidate != owner && this.isValidTarget(candidate));
candidate -> candidate != livingOwner && this.isValidTarget(candidate));
return serverLevel.getNearestEntity(
candidates,
TARGET_PREDICATE,
owner instanceof LivingEntity livingOwner ? livingOwner : null,
livingOwner,
this.getX(),
this.getEyeY(),
this.getZ());
Expand Down
Loading