guard recursive comparisons against stack exhaustion - #1078
Open
atharvmantri wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound recursive JSON comparisons by the existing
CJSON_NESTING_LIMIT.cJSON_Compare()recursively descends arrays and objects without a depth check, and the private comparison used by JSON Patchtestand merge-patch generation has the same behavior. Deep or cyclic caller-supplied trees can therefore exhaust the native stack even though parsing, printing, and duplication already enforce recursion limits.This change keeps the public API unchanged, threads a depth counter through the internal recursion, and returns
falsewhen the configured limit is reached. The merge-patch generator also carries the limit instead of re-entering through the public wrapper, and propagates a failed nested patch rather than silently dropping it. Both comparison paths use the existing project-wide limit rather than introducing a second policy.Related: #1073.
Testing
git diff --check