Skip to content

fix(agentless): use proxy for otlp export - #10176

Merged
bwoebi merged 3 commits into
masterfrom
bob/otlp-proxy
Sep 7, 2026
Merged

fix(agentless): use proxy for otlp export#10176
bwoebi merged 3 commits into
masterfrom
bob/otlp-proxy

Conversation

@bwoebi

@bwoebi bwoebi commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

This ensures that in particular otlp logs and metrics are properly exported as well.

This ensures that in particular otlp logs and metrics are properly exported as well.
@bwoebi
bwoebi requested review from a team as code owners September 6, 2026 01:28
@bwoebi
bwoebi requested a review from BridgeAR September 6, 2026 01:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T15:45:14.673478Z c3193f7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dd-octo-sts

dd-octo-sts Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.84 MB
Deduped: 9.5 MB
No deduping: 9.5 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 6, 2026

Copy link
Copy Markdown

Tests

All CI checks and tests passed. Datadog automation helped this PR pass.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 98.13% (-0.10%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fac7864 | Docs | View more details | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da93fa5edc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/dd-trace/src/opentelemetry/otlp/otlp_http_exporter_base.js
@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.67%. Comparing base (ca391e1) to head (fac7864).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10176      +/-   ##
==========================================
+ Coverage   98.65%   98.67%   +0.02%     
==========================================
  Files        1005     1005              
  Lines      157435   157600     +165     
  Branches       74       74              
==========================================
+ Hits       155312   155513     +201     
+ Misses       2123     2087      -36     
Flag Coverage Δ
ai-guard 64.99% <0.00%> (-0.03%) ⬇️
apm-capabilities 63.86% <100.00%> (+0.76%) ⬆️
apm-integrations 81.41% <0.00%> (-0.02%) ⬇️
appsec 58.66% <0.00%> (-0.06%) ⬇️
debugger 69.81% <0.00%> (-0.03%) ⬇️
instrumentation 53.68% <0.00%> (-0.06%) ⬇️
llmobs 79.00% <100.00%> (-0.02%) ⬇️
master-coverage 98.67% <100.00%> (?)
openfeature 66.37% <100.00%> (-0.04%) ⬇️
platform 69.30% <57.14%> (-0.02%) ⬇️
profiling 66.74% <0.00%> (-0.03%) ⬇️
serverless 65.70% <0.00%> (-0.04%) ⬇️
test-optimization 82.80% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Sep 6, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-07 16:19:28

Comparing candidate commit fac7864 in PR branch bob/otlp-proxy with baseline commit ca391e1 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2306 metrics, 7 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable max_rss_usage [-28.270MB; +48.557MB] or [-9.868%; +16.950%]

scenario:debugger-enabled-but-breakpoint-not-hit-26

  • unstable cpu_user_time [-354.250ms; +674.232ms] or [-4.032%; +7.675%]
  • unstable execution_time [-354.550ms; +673.886ms] or [-4.034%; +7.667%]
  • unstable throughput [-2012443.746op/s; +1048553.723op/s] or [-7.055%; +3.676%]

scenario:encoders-0.4-immediate-flush-20

  • unstable max_rss_usage [-8451.226KB; +8778.084KB] or [-10.679%; +11.092%]

scenario:llmobs-encode-unicode-mixed-20

  • unstable max_rss_usage [-10.979MB; +7.681MB] or [-14.671%; +10.264%]

scenario:log-with-debug-24

  • unstable execution_time [-168.790ms; +248.011ms] or [-4.255%; +6.252%]

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is LGTM, while a test is missing

Comment thread packages/dd-trace/src/opentelemetry/otlp/otlp_http_exporter_base.js
@bwoebi
bwoebi requested a review from a team as a code owner September 7, 2026 16:07
@bwoebi
bwoebi merged commit ed0ad65 into master Sep 7, 2026
767 checks passed
@bwoebi
bwoebi deleted the bob/otlp-proxy branch September 7, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants