Skip to content

test: augusto/investigate-dd-trace-js-benchmark-failures_5beb67524 - #10164

Draft
igoragoli wants to merge 1 commit into
masterfrom
augusto/investigate-dd-trace-js-benchmark-failures_5beb67524
Draft

test: augusto/investigate-dd-trace-js-benchmark-failures_5beb67524#10164
igoragoli wants to merge 1 commit into
masterfrom
augusto/investigate-dd-trace-js-benchmark-failures_5beb67524

Conversation

@igoragoli

Copy link
Copy Markdown
Contributor

What does this PR do?

Motivation

Additional Notes

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.77 MB
Deduped: 9.44 MB
No deduping: 9.44 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 4, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 59 Pipeline jobs failed

Electron | macos — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Error: Timeout of 30000ms exceeded during 'before all' hook for Electron integration test in electron.spec.js.

Electron | ubuntu — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

1 failed test. Error: Timeout of 30000ms exceeded while executing integration test in electron.spec.js.

AI Guard | AI Guard / macos — 🔄 Retry may pass, looks flaky

View more details · View in GitHub Actions

Job failed: execution took longer than 300000ms due to timeout.

View all 59 failed jobs.

📋 Copy fix prompt
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:

1. Check whether you already have the Datadog software-delivery MCP tools
   (e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
   anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
   server and skills by following:
     https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
   then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.

Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.

If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.

Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:

1. Locate the change. Diff this branch against its base and find the change
   that produces this error. Explain the mechanism, don't just name a file:
     git fetch origin && git diff $(git merge-base origin/master HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
   proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
   not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
   so plainly instead of "fixing" it — that is a flaky test, and patching it
   hides the problem.

If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).

Branch: augusto/investigate-dd-trace-js-benchmark-failures_5beb67524

Electron | macos
Commit: 346e34b6fd6d956e990407ec3d2af56835a3a4f3
Error (code / test):
Error: Timeout of 30000ms exceeded during 'before all' hook for Electron integration test in electron.spec.js.
CI job: https://github.com/DataDog/dd-trace-js/actions/runs/33868345779/job/101008215077

Electron | ubuntu
Commit: 346e34b6fd6d956e990407ec3d2af56835a3a4f3
Error (code / test):
1 failed test. Error: Timeout of 30000ms exceeded while executing integration test in electron.spec.js.
CI job: https://github.com/DataDog/dd-trace-js/actions/runs/33868345779/job/101008214889

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.86% (+10.27%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0ec2989 | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.88%. Comparing base (5beb675) to head (0ec2989).
⚠️ Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5beb675) and HEAD (0ec2989). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (5beb675) HEAD (0ec2989)
openfeature 1 0
platform 1 0
ai-guard 1 0
instrumentation 1 0
serverless 1 0
apm-integrations 1 0
appsec 1 0
test-optimization 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10164       +/-   ##
===========================================
- Coverage   98.63%   76.88%   -21.75%     
===========================================
  Files        1004      860      -144     
  Lines      155323   117931    -37392     
  Branches       74       26       -48     
===========================================
- Hits       153205    90677    -62528     
- Misses       2118    27254    +25136     
Flag Coverage Δ
ai-guard ?
apm-capabilities 62.97% <ø> (-0.01%) ⬇️
apm-integrations ?
appsec ?
debugger 69.63% <ø> (-0.01%) ⬇️
instrumentation ?
llmobs 78.93% <ø> (-0.07%) ⬇️
master-coverage 76.88% <ø> (?)
openfeature ?
platform ?
profiling 66.55% <ø> (-0.03%) ⬇️
serverless ?
test-optimization ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Sep 4, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-04 11:49:50

Comparing candidate commit 0ec2989 in PR branch augusto/investigate-dd-trace-js-benchmark-failures_5beb67524 with baseline commit 5beb675 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2304 metrics, 9 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable max_rss_usage [-41759.043KB; +43127.043KB] or [-14.224%; +14.690%]

scenario:encoders-0.4-immediate-flush-20

  • unstable max_rss_usage [-4.767MB; +12.656MB] or [-6.340%; +16.833%]

scenario:llmobs-encode-unicode-mixed-20

  • unstable max_rss_usage [-12.578MB; +5.922MB] or [-16.465%; +7.751%]

scenario:llmobs-span-processor-retrieval-20

  • unstable execution_time [-129.639ms; +201.936ms] or [-4.377%; +6.818%]

scenario:plugin-aws-sdk-eventbridge-inject-detail-24

  • unstable cpu_usage_percentage [-6.294%; +3.989%]
  • unstable execution_time [-208.758ms; +363.253ms] or [-4.282%; +7.451%]
  • unstable throughput [-83222.824op/s; +47309.184op/s] or [-6.739%; +3.831%]

scenario:plugin-graphql-long-with-depth-off-26

  • unstable execution_time [-233.155ms; +531.473ms] or [-3.084%; +7.030%]
  • unstable max_rss_usage [-18.069MB; +39.347MB] or [-8.790%; +19.141%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant