Repository navigation
[K9CODESEC-7237] Update to deno_core 0.356.0 - #980
Open
jasonforal wants to merge 3 commits into
Open
jasonforal wants to merge 3 commits into
jasonforal wants to merge 3 commits into
Conversation
jasonforal
added this pull request to stack #985
October 2, 2026 17:09
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency upgrade and required API adaptations are internally consistent, with no unresolved correctness issues found.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the static-analysis kernel to deno_core 0.356.0 and adapts error handling and runtime-cache testing to the updated APIs.
Changes:
- Upgrades
deno_coreand transitive dependencies. - Unboxes
JsErrorbefore conversion. - Runs cache-test V8 runtimes on separate synchronized threads.
| File | Description |
|---|---|
crates/static-analysis-kernel/Cargo.toml |
Updates deno_core. |
Cargo.lock |
Locks updated transitive dependencies. |
crates/static-analysis-kernel/src/analysis/ddsa_lib/runtime.rs |
Adapts boxed runtime errors. |
crates/static-analysis-kernel/src/analysis/ddsa_lib/test_utils.rs |
Adapts boxed test errors. |
crates/bins/src/bin/datadog_static_analyzer_server/rule_cache.rs |
Updates the multi-runtime cache test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…h two runtimes on the same thread. (v8 is now enforcing this, whereas it was more tolerate before)
jasonforal
force-pushed
the
jf/K9CODESEC-7237-4
branch
from
October 2, 2026 20:25
0689761 to
6928f4e
Compare
bahar-shah
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Updates
deno_coreto0.356.0The
JsErrorreceived is now boxed, so we need to extract the inner.Note
As a small aside, 0689761 is needed because the test was always relying on v8 being lax about two runtimes on the same thread. Something must've changed in v137 that tightened this up, so we need to fix the test here. No test behavior changed.