Fix helper paths with scoped plugin manifests - #58
Merged
DanielLemky merged 1 commit intoSep 8, 2026
Conversation
DanielLemky
approved these changes
Sep 8, 2026
DanielLemky
left a comment
Owner
There was a problem hiding this comment.
Thanks for the fix and the clear regression coverage. I tested it locally against my Omarchy instance. Omalaunch opened correctly, helper-backed actions used the correct plugin path, and Web Search completed successfully. I found no missing helper-path errors in the logs. Approved.
DanielLemky
approved these changes
Sep 8, 2026
DanielLemky
left a comment
Owner
There was a problem hiding this comment.
Thanks for the fix and the clear regression coverage. I tested it locally against my Omarchy instance. Omalaunch opened correctly, helper-backed actions used the correct plugin path, and Web Search completed successfully. I found no missing helper-path errors in the logs. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve Omalaunch's helper directory from its own QML component URL instead of
manifest.__sourceDir.Omarchy now removes private fields from the manifest it gives third-party plugins. With Omalaunch 0.3.0 on
omarchy-dev 4.0.0.r2071.ga703092-1,pluginPathbecame empty and opening the launcher logged:The same empty prefix affects provider configuration, agent, and file-index helper paths.
Qt.resolvedUrl(".")locates the installed component without private host metadata or a hard-coded plugin directory. Decode URL escapes so paths containing spaces,#, and%remain usable.Validation
Passed:
node tests/qml-extension-path-test.js— 80 assertions, including new cases without__sourceDirand with escaped path characters. The new regression fails on the original implementation.node tests/menu-model-test.js— 354 assertions.PATH=/usr/bin:/bin /usr/bin/python3 tests/extension-loader-test.py— 51 assertions. The explicit system PATH avoids a local mise shim rejecting the test's temporary HOME; no trust settings changed.git diff --check.Applied the same one-line change to the installed plugin and restarted the shell: the helper resolves to the installed Omalaunch directory and the missing-executable error disappears. Settings were not reset.
Companion host bug
The empty Apps menu also exposed a separate Omarchy bug: Qt's model conversion changes the nested manifest array's type, so the host fails its menu capability check and injects a null app library. It also omits the icon-refresh completion signal Omalaunch expects.
Companion fix and runtime regression: omacom/omarchy#10671
This PR fixes helper lookup only. Restoring the app list on the affected host needs the companion fix as well. The patched full desktop has not yet been visually verified; the packaged Omarchy files remain unchanged.