Skip to content

Fix helper paths with scoped plugin manifests - #58

Merged
DanielLemky merged 1 commit into
DanielLemky:masterfrom
smillunchick:fix/omarchy-plugin-api
Sep 8, 2026
Merged

Fix helper paths with scoped plugin manifests#58
DanielLemky merged 1 commit into
DanielLemky:masterfrom
smillunchick:fix/omarchy-plugin-api

Conversation

@smillunchick

Copy link
Copy Markdown
Contributor

Summary

Resolve Omalaunch's helper directory from its own QML component URL instead of manifest.__sourceDir.

Omarchy now removes private fields from the manifest it gives third-party plugins. With Omalaunch 0.3.0 on omarchy-dev 4.0.0.r2071.ga703092-1, pluginPath became empty and opening the launcher logged:

Process failed to start ... Command: QList("/libexec/load-extensions.py", "", "/usr/share/omarchy")

The same empty prefix affects provider configuration, agent, and file-index helper paths. Qt.resolvedUrl(".") locates the installed component without private host metadata or a hard-coded plugin directory. Decode URL escapes so paths containing spaces, #, and % remain usable.

Validation

Passed:

  • node tests/qml-extension-path-test.js — 80 assertions, including new cases without __sourceDir and with escaped path characters. The new regression fails on the original implementation.
  • node tests/menu-model-test.js — 354 assertions.
  • PATH=/usr/bin:/bin /usr/bin/python3 tests/extension-loader-test.py — 51 assertions. The explicit system PATH avoids a local mise shim rejecting the test's temporary HOME; no trust settings changed.
  • git diff --check.

Applied the same one-line change to the installed plugin and restarted the shell: the helper resolves to the installed Omalaunch directory and the missing-executable error disappears. Settings were not reset.

Companion host bug

The empty Apps menu also exposed a separate Omarchy bug: Qt's model conversion changes the nested manifest array's type, so the host fails its menu capability check and injects a null app library. It also omits the icon-refresh completion signal Omalaunch expects.

Companion fix and runtime regression: omacom/omarchy#10671

This PR fixes helper lookup only. Restoring the app list on the affected host needs the companion fix as well. The patched full desktop has not yet been visually verified; the packaged Omarchy files remain unchanged.

@DanielLemky DanielLemky left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the clear regression coverage. I tested it locally against my Omarchy instance. Omalaunch opened correctly, helper-backed actions used the correct plugin path, and Web Search completed successfully. I found no missing helper-path errors in the logs. Approved.

@DanielLemky DanielLemky left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the clear regression coverage. I tested it locally against my Omarchy instance. Omalaunch opened correctly, helper-backed actions used the correct plugin path, and Web Search completed successfully. I found no missing helper-path errors in the logs. Approved.

@DanielLemky
DanielLemky merged commit 6cec1fa into DanielLemky:master Sep 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants