Add datasource datapoint lookup by path - #717
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📜 Recent review details🔇 Additional comments (2)
📝 WalkthroughWalkthrough
ChangesDatapoint path lookup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds a localized datapoint lookup method with missing-path handling and focused tests; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
Summary
Datasource.get_datapoint(path)for direct datapoint lookupKeyErrorwhen the requested path does not existTests
PYTHONPATH="$PWD" python -m pytest tests/data_engine/test_datasource.py -qPYTHONPATH="$PWD" python -m pytest tests/data_engine/test_querying.py tests/data_engine/test_queryresult.py tests/data_engine/test_datapoint.py -qpython -m black --check dagshub/data_engine/model/datasource.py tests/data_engine/test_datasource.pygit diff --checkFixes #365