-
Notifications
You must be signed in to change notification settings - Fork 34
Show complete help text for dagshub repo create #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Muhtasim-Munif-Fahim
wants to merge
2
commits into
DagsHub:main
Choose a base branch
from
Muhtasim-Munif-Fahim:fix/repo-create-help-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| from click.testing import CliRunner | ||
|
|
||
| from dagshub.common.cli import cli | ||
|
|
||
|
|
||
| def _help(*args): | ||
| result = CliRunner().invoke(cli, [*args, "--help"]) | ||
| assert result.exit_code == 0, result.output | ||
| return result.output | ||
|
|
||
|
|
||
| def test_repo_group_help_lists_a_complete_summary_for_create(): | ||
| """ | ||
| The command listing used to be built from the first line of the docstring, | ||
| which ended in a colon and read as truncated output. | ||
| """ | ||
| output = _help("repo") | ||
|
|
||
| assert "Create a repo, optionally uploading data to it and cloning it" in output | ||
| # The dangling summary the listing used to end on. | ||
| assert "create a repo and optionally:" not in output | ||
|
|
||
|
|
||
| def test_repo_create_help_keeps_its_structure(): | ||
| """ | ||
| The bullet list and the examples are pre-formatted, so click must not | ||
| rewrap them into a single run-on paragraph. | ||
| """ | ||
| output = _help("repo", "create") | ||
|
|
||
| # Assert the rendered structure, not just that fragments appear somewhere: | ||
| # a later rewrap could satisfy substring checks while breaking the layout. | ||
| lines = [line.rstrip() for line in output.splitlines()] | ||
|
|
||
| assert " - upload a file to 'data' from a URL using the `-u` flag." in lines | ||
| assert " .zip and .tar files are extracted, other formats are copied as is." in lines | ||
| assert " - clone the repo locally using the `--clone` flag." in lines | ||
|
|
||
| assert " Example 1:" in lines | ||
| assert ( | ||
| ' dagshub repo create mytutorial -u "http://example.com/data.csv" --clone' | ||
| in lines | ||
| ) | ||
| assert " Example 2:" in lines | ||
|
|
||
| # The rewrapped remnant of the un-escaped bullet. | ||
| assert "are extracted, other formats" not in output |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.