Skip to content

Adjustments toward Phlexifying CAFMaker - #121

Draft
knoepfel wants to merge 1 commit into
DUNE:developfrom
knoepfel:phlex-cafmaker
Draft

Adjustments toward Phlexifying CAFMaker#121
knoepfel wants to merge 1 commit into
DUNE:developfrom
knoepfel:phlex-cafmaker

Conversation

@knoepfel

@knoepfel knoepfel commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

This PR is intended to illustrate the kinds of changes that would enable CAFMaker's functionality to be conducive for the Phlex framework.

The biggest changes:

  • Functions that were filling data objects now directly return them (sometimes std::tuple<T, U>s)
  • Some art functionalities that were being used in deeply embedded functions have been extracted to higher-level functions (e.g. analyze(art::Event const&)).
  • Some modest removal of art::Ptr<T> usage

@knoepfel
knoepfel marked this pull request as draft March 4, 2026 15:30
@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for DUNE Succeeded on slf7 for c14:prof -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for DUNE Failed at phase build DUNE on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build DUNE phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants