Skip to content

Add error message when failing to load DAQModule plugins #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eflumerf wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add error message when failing to load DAQModule plugins #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
459526e
Add ers::error call when fialing to load DAQModule plugins, as this can
eflumerf Jun 26, 2026
347e0e2
Merge remote-tracking branch 'origin/develop' into eflumerf/AddErrorM…
eflumerf Jun 26, 2026
517b531
More precise checks of the cause of the DAQModuleCreationFailed excep…
eflumerf Jun 30, 2026
18bbe5d
Merge branch 'develop' into eflumerf/AddErrorMessage
eflumerf Jul 14, 2026
f62b051
Merge remote-tracking branch 'origin/develop' into eflumerf/AddErrorM…
eflumerf Sep 1, 2026
0fd33a7
Merge remote-tracking branch 'origin/develop' into eflumerf/AddErrorM…
eflumerf Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/appfwk/detail/DAQModule.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ make_module(std::string const& plugin_name, std::string const& instance_name)
try {
mod_ptr = bpf.makePlugin<std::shared_ptr<DAQModule>>(plugin_name, instance_name);
} catch (const cet::exception& cexpt) {
ers::error(DAQModuleCreationFailed(ERS_HERE, plugin_name, instance_name, cexpt));
throw DAQModuleCreationFailed(ERS_HERE, plugin_name, instance_name, cexpt);
}
return mod_ptr;
Expand Down
11 changes: 8 additions & 3 deletions unittest/DAQModule_test.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,14 @@ BOOST_AUTO_TEST_CASE(Commands)

BOOST_AUTO_TEST_CASE(MakeModule)
{
BOOST_REQUIRE_EXCEPTION(make_module("not_a_real_plugin_name", "error_test"),
DAQModuleCreationFailed,
[&](DAQModuleCreationFailed) { return true; });
BOOST_REQUIRE_EXCEPTION(
make_module("not_a_valid_plugin_name", "error_test"), DAQModuleCreationFailed, [&](DAQModuleCreationFailed e) {
return e.cause()->message().find("contains an illegal underscore") != std::string::npos;
});
BOOST_REQUIRE_EXCEPTION(
make_module("not-a-real-plugin-name", "error_test"), DAQModuleCreationFailed, [&](DAQModuleCreationFailed e) {
return e.cause()->message().find("does not correspond to any library") != std::string::npos;
});
}

BOOST_AUTO_TEST_CASE(RegisterCommand)
Expand Down
Loading