Repository navigation
Pin raxol_payments parity to @xochi/spec - #1234
Open
DROOdotFOO wants to merge 5 commits into
Open
DROOdotFOO wants to merge 5 commits into
DROOdotFOO wants to merge 5 commits into
Conversation
DROOdotFOO
added this pull request to stack #1251
October 12, 2026 17:55
DROOdotFOO
force-pushed
the
pin-riddler-spec
branch
from
October 12, 2026 17:57
6023d3d to
904035a
Compare
Unified Regression Test ResultsWorkflow: Unified Regression Testing Performance ResultsFound 1 performance result(s) Memory ResultsFound 3 memory result(s) Targets
|
Conformance vectors and the vendored fee oracle are now read from the published @riddler/spec release pinned in test/fixtures/RIDDLER_SPEC_VERSION, never a sibling checkout. Under CI a missing artifact fails instead of passing over zero vectors. CI stays red until @riddler/spec@0.8.0 is published to npm.
@riddler/spec moved to xochi-fi/xochi-sdk as @xochi/spec, so the pin, module and env var follow (XOCHI_SPEC_VERSION, XochiSpec, XOCHI_SPEC_DIR) and CI packs @xochi/spec. The taker CLI moved into Riddler as the private packages/e2e-signer; CliSigner runs its built dist/cli.js from a Riddler checkout (RIDDLER_CLI_DIR), still a local-only tag.
The pin named 0.8.0, which xochi-sdk never published and never will: packages/spec/package.json on its main branch is 0.8.1 and the spec CHANGELOG calls 0.8.0 "the never-published" version that every pre-fix commit declared. The release workflow refuses a spec-v* tag whose version differs from package.json, so there is no path by which `npm pack @xochi/spec@0.8.0` stops answering 404, and the Package Tests (raxol_payments) cell would have stayed red after the publish the PR waits on. 0.8.1 is a PATCH with no vector or schedule change: against a tarball packed from xochi-sdk main, every conformance vector and the fee oracle byte-identity test pass with this pin, and only the manifest version assertion failed under the old one.
Under CI an absent fixture now raises, but a fixture that loads and carries no vectors for a protocol still produced a green run: the `for vec <- by_protocol(...)` in each conformance module generates one test per vector, so an upstream rename of the "permit2" or "erc3009" protocol key, or a filtered fixture, left those describes empty and the cell green having asserted nothing. The Xochi module already guards against this with a "fixture coverage" test; Permit2 and x402 did not. Each now carries the same guard. Pointed at a fixture holding only xochi vectors, both guards fail and nothing else runs; against the pinned release's conformance.json they pass alongside the 46 generated tests.
FeeSchedule's docs pointed the reader at `@xochi/reference`'s `fee.ts` for the TypeScript side of the fee schedule, but that package has no such file: it is a private, unpublished test harness whose `fee.test.ts` only re-checks the published vectors. The mirror itself, `FEE_SCHEDULE` and `computeFeeBreakdown`, lives in `@xochi/client` (`packages/client/ src/fee.ts`), which is also what the spec's `fee/generate.ts` imports to produce `schedule.json`. Both the module doc and the parity test's doc now name the package that actually holds it.
DROOdotFOO
force-pushed
the
pin-riddler-spec
branch
from
October 15, 2026 21:36
1ebf0b3 to
335312a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: this needs
@xochi/spec0.8.0 /@xochi/signer0.5.0 /@xochi/client0.1.0 published from xochi-fi/xochi-sdk first (tagsspec-v0.8.0,signer-v0.5.0,client-v0.1.0,widget-lib-v0.1.0). After the publish, runmerge. Until then,npm ci` / frozen-lockfile CI fails by design.Stacked on the commerce-removal PR.
What
npm pack @xochi/spec@<test/fixtures/XOCHI_SPEC_VERSION>viaXOCHI_SPEC_DIRandCONFORMANCE_FIXTURE_PATH. UnderCIa missing fixture now raises; previously CI passed over 0 vectors.packages/e2e-signer(a local-only tag).Manual testing
CI=1and no fixture: fails