cptbox: compare projected with real instead of normalized - #1002
Open
Riolku wants to merge 1 commit into
Open
Conversation
We should compare `projected` with `real` instead of `normalized`. This is because if our file is `/proc/self/maps`, the projected will be `/proc/getpid()/maps`, and the real path is `/proc/getpid()/maps`. We do a useless `os.samefile` call in this case.
Collaborator
|
Can one of the admins verify this patch? |
Member
|
ok to test |
Xyene
requested changes
Feb 28, 2022
Xyene
left a comment
Xyene
left a comment
Member
There was a problem hiding this comment.
This makes the normalized computation dead code.
Contributor
Author
|
Not true. The jail still needs to check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should compare
projectedwithrealinstead ofnormalized. This is because if our file is/proc/self/maps, the projected will be/proc/getpid()/maps, and the real path is/proc/getpid()/maps. We do a uselessos.samefilecall in this case.