refactor: extract shared message protocol for runner and launcher - #14
Draft
AnemoFlower wants to merge 1 commit into
Draft
refactor: extract shared message protocol for runner and launcher#14AnemoFlower wants to merge 1 commit into
AnemoFlower wants to merge 1 commit into
Conversation
AnemoFlower
marked this pull request as draft
June 14, 2026 08:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new shared message protocol library to standardize communication between the
RunnerandLauncherexecutables, and refactors both to use this protocol for inter-process messaging over Unix Domain Sockets. The changes improve code maintainability, robustness, and clarity in the message exchange mechanism.Protocol and Communication Refactoring:
MessageProtocollibrary target, which defines a unifiedMessageenum and encoding/decoding logic for inter-process communication. BothRunnerandLaunchernow depend on this library. (Package.swift,Sources/MessageProtocol/Protocol.swift,Sources/MessageProtocol/ByteReader.swift) [1] [2] [3]RunnerandLauncherto use the newMessageProtocolfor all socket communication, replacing custom byte handling with structured message encoding/decoding. (Sources/Runner/main.swift,Sources/Launcher/main.swift) [1] [2] [3] [4] [5] [6]Code Simplification and Robustness:
ByteReaderandSocketReaderabstractions, improving error handling and code clarity. (Sources/MessageProtocol/ByteReader.swift,Sources/Launcher/main.swift) [1] [2]Sources/MessageProtocol/Protocol.swift,Sources/Launcher/main.swift) [1] [2]Minor Cleanups:
Sources/Launcher/main.swift) [1] [2]