Split exts_filter and custom_commands - #2
Open
Flamefire wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the approach I proposed in easybuilders#4146 (comment)
Basically:
exts_filteris the simple "does this package exist"-check (I think) it was supposed to becustom_commandsis a (sanity) check that the package(s) workThis also reinstantiates the
'dirs': [os.path.join('packages', self.name)],check removed in commit764e925(#4146) which would then be missing from standalone JuliaPackages.That affects so far
PlutoandSuppressorI guess the real issue is that
JuliaBundleinherits fromJuliaPackagewhich means every bundle is assumed to be a package and some/(most?) of the work in easybuilders#4146 is to workaround that mistake.