Optional create auth and gas tank service - #13
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates service initialization and API routing to make the AccountAbstract (auth) and GasTank services optional based on configuration, and updates the example environment file accordingly.
Changes:
- Make
service.Newonly constructAccountAbstractandGasTankPaymasterwhen corresponding contract addresses are configured. - Conditionally register
/aa/auth/*and/aa/gastank/*routes only when those services are enabled. - Update
.env.exampleto document how to enable/disable these optional services (and adjust default rate-limit values).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
service/service.go |
Builds Services with optional AccountAbstract and GasTank based on configured addresses. |
api/route.go |
Registers AA/GasTank routes only when the services are non-nil; adjusts default rate limits. |
.env.example |
Documents optional enabling via env vars; comments out GasTank address by default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is