Hide questions no remaining benefit needs - #506
Merged
prestoncabe merged 3 commits intoSep 22, 2026
Merged
prestoncabe merged 3 commits into
prestoncabe merged 3 commits into
Conversation
Hiding was opted out of per ineligible benefit, and every evaluation reset that opt-out. A benefit with two unanswered questions re-hid them after the first answer was submitted, so the user had to reopen it for each field. The per-benefit button was also offered whenever a benefit was ineligible, even when another benefit still voted for its questions and nothing was hidden. Replace it with a single showAllQuestions toggle that only the user writes. The form now ends with a notice counting the questions no remaining benefit needs; once shown, they stay visible through every re-evaluation until the user toggles back. Also preserve the live form state across a schema re-import. The re-import restored the last submitted data, so answers typed while a debounced submit was in flight were silently dropped from the form while the pending submit still sent them to the server. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
prestoncabe
force-pushed
the
503-eligibility-checks-should-vote-for-questions-on-the-form
branch
from
September 22, 2026 15:33
16fedbd to
c02c6f1
Compare
prestoncabe
deleted the
503-eligibility-checks-should-vote-for-questions-on-the-form
branch
September 22, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #503 (though the strategy has been altered a bit from the initial idea)
Summary
Testing