Fix: completers: Avoid repeated node completions - #2168
Draft
liangxin1300 wants to merge 1 commit into
Draft
Conversation
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
liangxin1300
force-pushed
the
20260805_improve_completers
branch
2 times, most recently
from
August 6, 2026 15:05
c2952ef to
4e176c0
Compare
Repeating completers suggested values that had already been completed. This made multi-value commands offer duplicate nodes, resources, or properties, and made commands with only one node argument keep completing nodes in later positions. - Add an exclude_completed completer wrapper - Filter repeated node, object, and property completions - Use positional completion for resource move and ban - Reuse the shared node completer for corosync push - Use positional completion for corosync link removal
liangxin1300
force-pushed
the
20260805_improve_completers
branch
from
August 7, 2026 08:05
4e176c0 to
728f265
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node-based completers could keep suggesting arguments that were already completed. This made commands such as cluster remove offer duplicate node choices, while resource move and ban repeated node completion beyond their single node argument.