Skip to content

Dev: migration: Add --force-breaks-pacemaker switch to bypass health check blockers (bsc#1250586) - #2161

Open
nicholasyang2022 wants to merge 2 commits into
ClusterLabs:masterfrom
nicholasyang2022:force-breaks-pacemaker
Open

Dev: migration: Add --force-breaks-pacemaker switch to bypass health check blockers (bsc#1250586)#2161
nicholasyang2022 wants to merge 2 commits into
ClusterLabs:masterfrom
nicholasyang2022:force-breaks-pacemaker

Conversation

@nicholasyang2022

Copy link
Copy Markdown
Collaborator

Allows users to force the corosync configuration migration even if CIB
prerequisite checks return critical blockers (such as unsupported resource or
fence agents). This enables starting the cluster in an unsupported state on
the new OS so that users can carry out manual actions to fix the unsupported
agents afterwards.

  • Adds --force-breaks-pacemaker option to the migration parser.
  • Skips _check_impl() and runs migrate_corosync_conf() directly if the switch is set.
  • Adds new unit tests to test_migration.py verifying the bypass logic.
  • Adds a functional test scenario to migration.feature to test the bypass behavior under blocker conditions.

@nicholasyang2022 nicholasyang2022 changed the title Dev: migration: Add --force-breaks-pacemaker switch to bypass health check blockers Dev: migration: Add --force-breaks-pacemaker switch to bypass health check blockers (bsc#1250586) Jul 23, 2026
@nicholasyang2022
nicholasyang2022 force-pushed the force-breaks-pacemaker branch from 86ebdc6 to 48c031e Compare July 23, 2026 07:59
…check blockers (bsc#1250586)

Allows users to force the corosync configuration migration even if CIB
prerequisite checks return critical blockers (such as unsupported resource or
fence agents). This enables starting the cluster in an unsupported state on
the new OS so that users can carry out manual actions to fix the unsupported
agents afterwards.

- Adds --force-breaks-pacemaker option to the migration parser.
- Skips _check_impl() and runs migrate_corosync_conf() directly if the switch is set.
- Adds new unit tests to test_migration.py verifying the bypass logic.
- Adds a functional test scenario to migration.feature to test the bypass behavior under blocker conditions.
@nicholasyang2022
nicholasyang2022 force-pushed the force-breaks-pacemaker branch from 48c031e to e358836 Compare July 23, 2026 09:30
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.59%. Comparing base (849ba1d) to head (fdec767).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 55.36% <100.00%> (+0.02%) ⬆️
unit 52.61% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/migration.py 87.07% <100.00%> (+1.45%) ⬆️
crmsh/ui_cluster.py 71.97% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nicholasyang2022
nicholasyang2022 marked this pull request as ready for review July 27, 2026 08:26

@liangxin1300 liangxin1300 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Thanks!

@liangxin1300

Copy link
Copy Markdown
Collaborator

Need also to mention this new option in crm help

@liangxin1300
liangxin1300 requested a review from zzhou1 July 28, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants