Skip to content

[crmsh-4.6] support crm cluster copy to copy directory #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liangxin1300 wants to merge 5 commits into
base: crmsh-4.6
Choose a base branch
from
Open

[crmsh-4.6] support crm cluster copy to copy directory #1911

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28c7fd3
Dev: utils: Improve cluster_copy_file with absolute path, dir check, …
liangxin1300 Sep 8, 2025
7c42789
Dev: Rename function utils.cluster_copy_file to utils.cluster_copy_path
liangxin1300 Sep 8, 2025
f410851
Dev: doc: Update help text for crm cluster copy subcommand
liangxin1300 Sep 8, 2025
5862937
Dev: behave: Adjust functional test for previous commit
liangxin1300 Sep 10, 2025
40fb852
Dev: unittests: Adjust unit test for previous commit
liangxin1300 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions crmsh/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1990,17 +1990,40 @@ def cluster_copy_file(local_path, nodes=None, output=True):
"""
if not nodes:
nodes = list_cluster_nodes_except_me()
rc = True
if not nodes:
return rc
results = prun.pcopy_to_remote(local_path, nodes, local_path)
return True

p = Path(local_path)
if not p.exists():
logger.error("%s does not exist", local_path)
return False

if p.is_absolute():
source_path = local_path
parent_path = p.parent
else:
absolute_path = p.resolve()

@nicholasyang2022 nicholasyang2022 Sep 23, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When p is a symlink /foo/link -> /bar, should we copy the symlink /foo/link or the link target /bar?

source_path = str(absolute_path)
parent_path = absolute_path.parent
mkdir_cmd = f"test -d {parent_path} || mkdir -p {parent_path}"
crmsh.parallax.parallax_call(nodes, mkdir_cmd)

recursive = False
sync_type = "file"
target_path = source_path
if p.is_dir():
recursive = True
sync_type = "directory"
target_path = parent_path

rc = True
results = prun.pcopy_to_remote(source_path, nodes, target_path, recursive=recursive)
for host, exc in results.items():
if exc is not None:
logger.error("Failed to copy %s to %s@%s: %s", local_path, exc.user, host, exc)
logger.error("Failed to copy %s to %s@%s: %s", source_path, exc.user, host, exc)
rc = False
else:
logger.info("%s", host)
logger.debug("Sync file %s to %s", local_path, host)
logger.info("Sync %s %s to %s", sync_type, source_path, host)
return rc


Expand Down